Skip to content

Throw exception for store side failures in Import-AzDataLakeStoreItem, Export-AzDataLakeStoreitem#11376

Closed
rahuldutta90 wants to merge 1 commit intomasterfrom
task-adls-throwexceptionbulktransfer
Closed

Throw exception for store side failures in Import-AzDataLakeStoreItem, Export-AzDataLakeStoreitem#11376
rahuldutta90 wants to merge 1 commit intomasterfrom
task-adls-throwexceptionbulktransfer

Conversation

@rahuldutta90
Copy link
Contributor

@rahuldutta90 rahuldutta90 commented Mar 19, 2020

Description

This does not change behavior in the successful cases, For failures earlier it used to write to the screen about the failure, now it will throw exceptions.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@rahuldutta90 rahuldutta90 requested a review from isra-fel March 19, 2020 21:32
@rahuldutta90 rahuldutta90 added this to the S167 (2020-03-31) milestone Mar 19, 2020
@isra-fel isra-fel self-assigned this Mar 20, 2020
@isra-fel
Copy link
Member

isra-fel commented Mar 20, 2020

This is considered a breaking change, because user must update their scripts to catch the new exception.
Here's our recommendation:

  1. add breaking change description to the two cmdlets, telling the user that they'll be changed
  2. (optional) release preview that has the breaking change if necessary
  3. Check in the breaking change during our special release (around May)

@isra-fel isra-fel added Contains Breaking Change This PR contains breaking change needs-revision and removed needs-review labels Mar 20, 2020
@isra-fel isra-fel assigned rahuldutta90 and unassigned isra-fel Mar 20, 2020
@rahuldutta90
Copy link
Contributor Author

rahuldutta90 commented Mar 23, 2020 •
edited
Loading

This is considered a breaking change, because user must update their scripts to catch the new exception.
Here's our recommendation:

  1. add breaking change description to the two cmdlets, telling the user that they'll be changed
  2. (optional) release preview that has the breaking change if necessary
  3. Check in the breaking change during our special release (around May)

@isra-fel Agree. I have sent out a pr: #11404 What is the date i should put as per https://github.com/Azure/azure-powershell/blob/master/documentation/breaking-changes/breaking-changes-attribute-help.md#with-deprecatedbyversion-and-changeineffectbydate

@isra-fel
Copy link
Member

isra-fel commented Mar 24, 2020 •
edited
Loading

Continuing our conversation in #11404
Closing the PR for now as it won't be merged until the breaking change release (starting April 14th)
Please feel free to reopen then.
Thanks

@isra-fel isra-fel closed this Mar 24, 2020
@wyunchi-ms wyunchi-ms deleted the task-adls-throwexceptionbulktransfer branch January 10, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isra-fel isra-fel Awaiting requested review from isra-fel

Assignees

@rahuldutta90 rahuldutta90

Labels

Contains Breaking Change This PR contains breaking change needs-revision

Projects

None yet

Milestone

S169 (2020-05-18) - Build

Development

Successfully merging this pull request may close these issues.

2 participants

@rahuldutta90 @isra-fel